From 6368272cdeec8c69800b4e7645402914f48e5c33 Mon Sep 17 00:00:00 2001
From: seth <getchoo@tuta.io>
Date: Tue, 9 Jul 2024 06:45:24 -0400
Subject: modules: better document most things

---
 modules/nixos/traits/nvidia.nix | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'modules/nixos/traits/nvidia.nix')

diff --git a/modules/nixos/traits/nvidia.nix b/modules/nixos/traits/nvidia.nix
index 5fec7db..1b37086 100644
--- a/modules/nixos/traits/nvidia.nix
+++ b/modules/nixos/traits/nvidia.nix
@@ -17,12 +17,13 @@ in
   config = lib.mkIf cfg.enable (
     lib.mkMerge [
       {
+        # NOTE: this is experiemental
         boot.kernelParams = lib.optional usingNvidia "nvidia_drm.fbdev=1";
 
         services.xserver.videoDrivers = [ "nvidia" ];
 
         hardware = {
-          graphics.extraPackages = [ pkgs.vaapiVdpau ];
+          graphics.extraPackages = [ pkgs.vaapiVdpau ]; # TODO: does this work...?
           nvidia = {
             package = lib.mkDefault config.boot.kernelPackages.nvidiaPackages.latest;
             modesetting.enable = true;
@@ -34,10 +35,14 @@ in
         specialisation = {
           nvk.configuration = {
             boot = {
+              # required for GSP firmware
               kernelParams = [ "nouveau.config=NvGspRm=1" ];
+              # we want early KMS 
+              # https://wiki.archlinux.org/title/Kernel_mode_setting#Early_KMS_start
               initrd.kernelModules = [ "nouveau" ];
             };
 
+            # TODO: make sure we don't need this anymore
             environment.sessionVariables = {
               MESA_VK_VERSION_OVERRIDE = "1.3";
             };
-- 
cgit v1.2.3